fix(compile): use workingDirectory for integrity check instead of absolute path#346
Merged
jamesadevine merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
…olute path Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/aa180f1e-5a9d-4660-ae43-941dae017d48 Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jamesadevine
April 28, 2026 16:34
View session
Collaborator
|
/rust-review |
jamesadevine
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verify pipeline integrityfailed for agents usingtools.azure-devopswhenevercheckout:listed additional repositories. The step had noworkingDirectory, so it ran from$(Build.SourcesDirectory)— which has no.gitin a multi-repo layout — andado-aw check's internal recompile couldn't infer the ADO org from the git remote:Changes:
generate_integrity_check— setworkingDirectory: {{ trigger_repo_directory }}on the step so the recompile runs from the trigger repo (which has.git).generate_pipeline_path— drop the{{ trigger_repo_directory }}/prefix; the path is now relative and resolves against the newworkingDirectory.generate_source_path— unchanged. The Stage 3 executor sets its ownworkingDirectory: {{ working_directory }}, which can point at an alias subfolder, so the source path must stay anchored at{{ trigger_repo_directory }}.{{ pipeline_path }}/{{ integrity_check }}updated.Resulting step (multi-repo case):
Test plan
generate_pipeline_path(relative output) andgenerate_integrity_check(assertsworkingDirectoryis set).cargo build,cargo test(914+ tests),cargo clippy --all-targets --all-featuresall pass.checkout:and confirmed the emitted step uses$(Build.SourcesDirectory)and$(Build.SourcesDirectory)/$(Build.Repository.Name)respectively.